Fix: making createMojo return Mojo objects (was previously restricted to SetMojo) #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
changed the title
andrzejj0
changed the title
andrzejj0
force-pushed
the
basetestcase-fix
branch
from
126653d
to
9d954ec
Compare
src/test/java/org/codehaus/mojo/versions/utils/BaseMojoTestCase.java
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
basetestcase-fix
branch
from
9d954ec
to
1a8edec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small correction to #656: it was previously restricted to SetMojo only, now making it more generic. A problem is that we're trying to access a property by name, perhaps there should be a common interface instead, but that's for another PR.