-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing #670: restoring allowSnapshots which was disabled in PR #665 #671
Merged
slawekjaranowski
merged 1 commit into
mojohaus:master
from
andrzejj0:issue-670-downgrade-with-allow-snapshots
Sep 6, 2022
Merged
Fixing #670: restoring allowSnapshots which was disabled in PR #665 #671
slawekjaranowski
merged 1 commit into
mojohaus:master
from
andrzejj0:issue-670-downgrade-with-allow-snapshots
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@slawekjaranowski please review |
Still getting
|
with what invocation arguments? did you use -DallowSnapshots ? |
|
As there is no reproducer in original issue, here's my pom: <?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.codehaus.mojo</groupId>
<artifactId>mojo-parent</artifactId>
<version>70</version>
</parent>
<groupId>mojohaus</groupId>
<artifactId>issue-670</artifactId>
<version>0.31-SNAPSHOT</version>
<packaging>pom</packaging>
</project> |
Or perhaps could you please refer to the artifacts in it-repo? |
andrzejj0
force-pushed
the
issue-670-downgrade-with-allow-snapshots
branch
from
September 6, 2022 14:08
4cfb878
to
2be4fa6
Compare
andrzejj0
commented
Sep 6, 2022
Thanks for the test case. Amended the PR. |
…usePluginRepositories was incorrectly enabled
andrzejj0
force-pushed
the
issue-670-downgrade-with-allow-snapshots
branch
from
September 6, 2022 14:45
2be4fa6
to
8395718
Compare
Also added that test as an it. |
@ajarmoniuk thanks for fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the problem related to snapshots in UpdateParentMojo + adding a unit test testing snapshots.