#454: Introducing "infinity-like" range calculus for dependency range computation #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski please review |
jarmoniuk
force-pushed
the
issue-454-allow-major-updates
branch
2 times, most recently
from
45615de
to
6d89989
Compare
jarmoniuk
changed the title
src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
Outdated
Show resolved
Hide resolved
jarmoniuk
force-pushed
the
issue-454-allow-major-updates
branch
from
6d89989
to
3115c68
Compare
|
Changes applied. Please re-review :) |
slawekjaranowski
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the next version for range calculation when considering version upgrades, I've devised a sort of a bounded artifact version where we use the concept of "infinity" on a given segment position to match all possible upper versions on the position, but nothing from the more major segment. So, 2.0.0-beta or similar won't be matched anymore when considering minor updates of the 1.x.x branch.
Tests added as unit tests; in particular, two for testing the case explained in #454 in
DisplayDependencyUpdatesMojoTestSome minor refactoring and typo corrections.