#637: Refactoring report renderers #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
force-pushed
the
doxia-renderers
branch
from
0a7e259
to
3e15ee6
Compare
src/main/java/org/codehaus/mojo/versions/reporting/DependencyUpdatesReportRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/reporting/ParentUpdatesReportRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/reporting/PluginUpdatesReportRenderer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/reporting/PropertyUpdatesReportRenderer.java
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/reporting/ReportRendererFactoryImpl.java
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/xml/PluginUpdatesXmlRenderer.java
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
doxia-renderers
branch
3 times, most recently
from
5707271
to
f28af5e
Compare
src/main/java/org/codehaus/mojo/versions/DependencyUpdatesReportMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PluginUpdatesReportMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/PropertyUpdatesReportMojo.java
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
doxia-renderers
branch
from
f28af5e
to
52bb179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to abstract a common model and make report renders more cohesive.
There is still way of improvement (for example: the report renderers should not compute things (extract data from VersionsHelper) on themselves, but they should just present data) but due to the size of this PR I've decided not to drag this indefinitely, but make a stop already on this stage. I think this could improve things already.