Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#454 Use BoundArtifactVersion with UpdatePropertiesMojo #753

Merged
merged 1 commit into from
Oct 14, 2022
Merged

#454 Use BoundArtifactVersion with UpdatePropertiesMojo #753

merged 1 commit into from
Oct 14, 2022

Conversation

andrzejj0
Copy link
Contributor

High prio PR, fixes #454 for UpdatePropertiesMojo

Regarding #454, perhaps it should be reopened 😄

@andrzejj0
Copy link
Contributor Author

@slawekjaranowski please review the same

@andrzejj0
Copy link
Contributor Author

Looks like this also fixes UpdatePropertyMojo.

@andrzejj0
Copy link
Contributor Author

andrzejj0 commented Oct 11, 2022 •
edited
Loading

Added unit tests for UpdatePropertyMojo, also added it for update-parent and resolve-ranges

@andrzejj0 andrzejj0 force-pushed the issue-454-update-properties branch 2 times, most recently from 418137e to 5b15832 Compare October 11, 2022 05:42
@slawekjaranowski
Copy link
Member

Please resolve conflicts

@andrzejj0
Copy link
Contributor Author

Done

@andrzejj0
mojohaus#454: Applying bound artifact versions to UpdatePropertiesMoj…
3b903d4 
…o, UpdatePropertyMojo + adding it tests for resolve-ranges and update-parent
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 14, 2022
@slawekjaranowski slawekjaranowski merged commit 954a853 into mojohaus:master Oct 14, 2022
@andrzejj0 andrzejj0 deleted the issue-454-update-properties branch October 14, 2022 13:54
@andrzejj0 andrzejj0 mentioned this pull request Oct 15, 2022
Closed
@andrzejj0 andrzejj0 mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of -DallowMajorReleases=false
2 participants
@andrzejj0 @slawekjaranowski