Fixing #755: Segment names containing Optional were used as tag names in XML reports

[jarmoniuk]

No description provided.

[jarmoniuk]

@slawekjaranowski @slachiewicz please review

[jarmoniuk]

By the way, I'm also almost done with a PR to use Modello for those XML reports, should be out today or tomorrow. That PR will replace these StringBuilder-based renderers.

[jarmoniuk]

Alternative: #757

[slawekjaranowski]

I'm for modelo - we can create XSD schema and documentation automatically.

[slawekjaranowski]

I suppose that this one can be closed, when we choose moelo alternative: #757

[jarmoniuk]

I suppose that this one can be closed, when we choose moelo alternative: #757

of course.

I'm currently working on this regression saw by @sultan -- #760.

The root cause is the fact that I was only adding "-snapshot" in incrementSegment to snapshot versions. This was initially done (before this "infinity calculus") because "-snapshot" is treated as the lowest possible version, lower than the release, which acts as a pseudo "minus infinity".

Well, I could either do that or introduce a real "minus infinity".

[jarmoniuk]

The "-segment" approach seems to be fixing the issue; trying the more ambitious approach ;)