Minor enhancement: use streams API in getNewestUpdates and getVersions #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
changed the title
andrzejj0
force-pushed
the
abstract-version-details-refactor
branch
from
157c25c
to
bf37bea
Compare
andrzejj0
changed the title
andrzejj0
changed the title
|
i believe streams are the way to go in 2022 👍 |
src/main/java/org/codehaus/mojo/versions/api/AbstractVersionDetails.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/api/AbstractVersionDetails.java
Outdated
Show resolved
Hide resolved
…in AbstractVersionDetails
andrzejj0
force-pushed
the
abstract-version-details-refactor
branch
from
bf37bea
to
9e1d044
Compare
|
I wonder, Instead of sending null ranges, could we send noop filters. And functions to create them like filterForXxx. The goal would be to reduce the number of functions maybe. What do you think is best ? |
@slawekjaranowski do you think we could have Discussions enabled here? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Streams API to streamline some of the methods, more concise and more readable in my (subjective) opinion.
Does not need to be added to the upcoming release.