Build Modello improvement, change namespace for xsd #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
slawekjaranowski
commented
Oct 17, 2022
slawekjaranowski
commented
- all Modello source will have the same version of model
- generate Modello documentation in model directory - we have the same report name as documentation for model
- change name space to https://www.mojohaus.org/VERSIONS/...
- preserver old version of rule.xsd
- all Modello source will have the same version of model - generate Modello documentation in model directory - we have the same report name as documentation for model - change name space to https://www.mojohaus.org/VERSIONS/... - preserver old version of rule.xsd
andrzejj0
reviewed
Oct 18, 2022
| @@ -21,8 +21,8 @@ under the License. | |||
|
|
|||
| <model xmlns="http://codehaus-plexus.github.io/MODELLO/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://codehaus-plexus.github.io/MODELLO/2.0.0 https://codehaus-plexus.github.io/modello/xsd/modello-2.0.0.xsd" | |||
| xsd.namespace="http://mojo.codehaus.org/versions-maven-plugin/dependency-updates-report/1.0.0" | |||
| xsd.targetNamespace="http://mojo.codehaus.org/versions-maven-plugin/dependency-updates-report/1.0.0"> | |||
| xml.namespace="https://www.mojohaus.org/VERSIONS/DEPENDENCY-UPDATES-REPORT/${version}" | |||
There was a problem hiding this comment.
Do we really want to change the namespace of the reports with every new release of the plugin?
There was a problem hiding this comment.
It is version of model form modello-maven-plugin configuration - it is not project version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.