Quality: Refactoring Reports classes #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased + javadoc for the added methods |
sultan
force-pushed
the
Refactor
branch
3 times, most recently
from
d9fb8c8
to
5198e9a
Compare
sultan
changed the title
sultan
force-pushed
the
Refactor
branch
2 times, most recently
from
bea286a
to
e0db12f
Compare
|
Looks ok, thanks. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal would be to shorten render methods by factorizing duplicate code
i'm not fully happy about the end result code so it's in draft but open to feedback/reviews
i believe the current code still gives a good idea of (some) cleaner methods