-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#758: Implementing the first stage of module split #782
#758: Implementing the first stage of module split #782
Conversation
@slawekjaranowski Please review. |
I think we need some kind of a commit freeze in order to commit this -- too many changes. |
3c55c9f
to
2bd0114
Compare
I have worked a little on site output. Please check by:
and investigate output in |
Maven site won't build anymore on Github.
Looks like maven site requires the artifacts to be present in the local repo. So we need to do By the way, why did you remove the XSD schemas of the reports from the XSD section? I can re-add those unless you explicitly wanted those removed... |
I moved it to place where is generated ... for old versions of XSD we will need place a copy in root site to preserver old path. |
I see - we use under site build current version of plugin ... it is tricky and sometime works, but with more dependencies for another module can stop working ... To be clear we should used previous version of plugin for site build. |
But that won't work - the previous version doesn't have modules 😏 Instead, why don't we do something like an extra Github Ci job before running site - Install with no tests, no enforcer, no chesktyle etc. Or compose that as an extra goal in the Site job? |
I changed to instal for first step build ... I'm waiting for build ... |
I'm want to go with this PR ... even more I can update site with snapshot version before release, so we can quickly resolve all site issues. Next PR like enforcer rule can be put in separate module - What do you think? |
Definitely! |
Can we merge? |
So, merged ... next release will be very interesting 😄 |
eeeh I forgot to squash 😠 |
No description provided.