Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-614 resolve version from model properties if necessary #796

Closed
wants to merge 2 commits into from

Conversation

TorstenKruse
Copy link
Contributor

@TorstenKruse TorstenKruse commented Oct 26, 2022

fixes issue 614 for reports

Copy link
Contributor

@jarmoniuk jarmoniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget about adding tests testing your changes :)

You can e.g. create a simple it test (or more) or add one or more methods to DependencyUpdatesReportMojoTest.

@TorstenKruse
Copy link
Contributor Author

Still unsure if this is the right way to implement the test, please review. Thanks.

BTW: IntelliJ is complaining about org.codehaus.mojo.versions.model.RuleSet - where to find this class?

@TorstenKruse TorstenKruse changed the title issue-794 resolve version from model properties if necessary issue-617 resolve version from model properties if necessary Oct 26, 2022
@TorstenKruse TorstenKruse changed the title issue-617 resolve version from model properties if necessary issue-614 resolve version from model properties if necessary Oct 26, 2022
@TorstenKruse TorstenKruse deleted the issue-794 branch October 26, 2022 13:08
@TorstenKruse
Copy link
Contributor Author

I'm sorry, renaming the branch seems to auto close the PR, please go on here: #797

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Oct 26, 2022 via email

@TorstenKruse
Copy link
Contributor Author

Great. Now it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants