Resolves #809: Extract the apis and common services to a separate module #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski please review |
Could you please restart the failed jobs? |
slawekjaranowski
requested changes
Nov 12, 2022
versions-api/src/test/java/org/codehaus/mojo/versions/ordering/MavenVersionComparatorTest.java
Outdated
Show resolved
Hide resolved
jarmoniuk
force-pushed
the
module-api
branch
from
50c1e86
to
a19857e
Compare
|
Changes applied. |
slawekjaranowski
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no clear distinction between API and service implementation, but this is the first step on the way to have it: here we're extracting a common separate module which can already act as a service layer.