Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Plugin API for ChangeRecorder #819

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Introduce Plugin API for ChangeRecorder #819

merged 1 commit into from
Nov 23, 2022

Conversation

slawekjaranowski
Copy link
Member

TODO

  • manual - how to write plugin extensions
  • document new code

@slawekjaranowski
Copy link
Member Author

I see that ChangeRecorder is only used when change is introduced to project.
But we can see that changeRecorder* parameters are also available for display mojos, so users can be confused.

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Nov 20, 2022 •
edited
Loading

@ajarmoniuk - Please look.

jarmoniuk
jarmoniuk reviewed Nov 20, 2022
View reviewed changes
Copy link
Contributor

@jarmoniuk jarmoniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. How about using Modello for building the xml file? 😄

versions-api/src/main/java/org/codehaus/mojo/versions/api/recording/ChangeRecord.java Outdated Show resolved Hide resolved
versions-common/src/main/java/org/codehaus/mojo/versions/recording/ChangeRecorderXML.java Show resolved Hide resolved
@slawekjaranowski slawekjaranowski mentioned this pull request Nov 21, 2022
Closed
jarmoniuk
jarmoniuk approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@jarmoniuk jarmoniuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we also have a link from the main index.md page (versions-maven-plugin/src/site/index.md) to the new module markdown file?

@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Nov 23, 2022
@slawekjaranowski slawekjaranowski merged commit 98db659 into master Nov 23, 2022
@slawekjaranowski slawekjaranowski deleted the change-recorder-api branch November 23, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmoniuk jarmoniuk jarmoniuk approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @jarmoniuk