Resolves #990: Check prerequisites if required enforcer Maven version is empty #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think it should take the greater of the two. I'll redo the PR. Also, I don't really think that they're should be a default maven version. Currently it's 3.2.5, which is the minimum version required by the versions plugin, but the POM being analysed is executed without the versions plugin being involved and thus 3.2.5 shouldn't be taken into account. -> #995 |
jarmoniuk
force-pushed
the
issue-990
branch
2 times, most recently
from
c03e633
to
a71610c
Compare
...ns-maven-plugin/src/main/java/org/codehaus/mojo/versions/MinimalMavenBuildVersionFinder.java
Outdated
Show resolved
Hide resolved
… version is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check prerequisites if enforcer check for Maven version is not present.
Prerequisites are checked after enforcer -- disputable, but at least this keeps the behavior backwards compatible.The plugin will choose the version which is the highest between: default maven version, prerequisites, enforcer.
@slawekjaranowski please check