Prevents god from resurrecting a keepalive process that has been stopped #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250, where god continues to monitor and resurrect a process after executing
god stop <task name>
. This particular issue occurs when usingkeepalive
, a custom stop command using aQUIT
signal, and a process that does not terminate within thestop_timeout
period.This commit forces a return after the execution of
ensure_stop
and prevents god from writing a new PID - the PID of a process spawned to run the custom stop command - and continuing to track the process which was previously killed.