Prevent segmentation fault in sync
and future
caches, and also upgrade crossbeam-epoch to v0.9.9
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Rewritten on July 19, 2022)
Changes
Prevent segmentation fault (use-after-free) in
sync
andfuture
caches. (Fixes #34):moka::cht
:cht
designed the rehashing to work fine in such situation, it is not working as expected.compare_exchange_weak
.Ordering::Release
, meaning read: relaxed, write: release.Ordering::AcqRel
, meaning read: acquire, write: release.Upgrade crossbeam-epoch from v0.8.2 to v0.9.9:
compare_and_set_weak
withcompare_exchange_weak
.Testing
Ran mokabench with the following arguments several times and no segmentation fault occurred.
$ cargo run --release -- --insert-once --repeat 20
Notes:
cht
from 64 to 1.Testing environment: