-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle usize
overflow on big cache capacity
#28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the multiply operation (`max_capacity * 32`) when setting the capacity of the popularity estimator (`FrequencySketch`). - The implementation of the estimator was replaced in an older version of Moka and the multiply operation was not really needed since then. - Add code to ensure that the capacity of the popularity estimator always fits within a range of `128u32..=u32::MAX`. - Change the type of the internal fields of the estimator from `usize` to `u32` so that the estimator will work consistency on any platform with different pointer width.
- Reduce the max size of the popularity estimator on platforms with 32-bit addressing. - Change the type of the internal table of the estimator from `Vec<u64>` to `Box<[u64]>`.
- Add unit test to ensure overflows not to happen and the sizes of the population estimators are correct.
- Not a bug but for clarity, avoid a lossy cast from `u64` to `u32` before applying the table mask.
tatsuya6502
commented
Aug 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging.
This was referenced Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #25,
usize
multiply overflow on big cache capacity.Changes
max_capacity * 32
) when setting the capacity of the popularity estimatorFrequencySketch
.128u32..=u32::MAX
.usize
tou32
so that the estimator will work consistency on any platform with different pointer width.Verification
sync::base_cache
andunsync::cache
modules to ensure overflows should not happen and sizes of the population estimators are correct:Fixes #25