-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge recent changes from maint-0.5 branch into master #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These platforms does not provide `std::sync::atomic::AtomicU64`. - Add a cargo feature "quanta" and make it a default feature. - Add a module `common::time` and conditionally choose the source file from "time_quanta.rs" or "time_compat.rs". - time_quanta.rs file has type aliases to `quanta::{Instant, Clock, Mock}`. It also has `AtomicInstant` holding an `AtomicU64`. - time_compat.rs file has `Instant` based on `std::time::Instant` and quanta-like `Clock` and `Mock`. It also has `AtomicInstant` holding a `RwLock<Option<Instant>>`. - Update Cache, etc. modules to use `common::time` instead of `quanta`. - Add a step to GitHub Actions to test future feature without quanta/ `AtomicU64`.
Remove some old codes.
Remove target_arch = "mips" from the cfg_attr for the time module. (It will not work when quanta feature is still enabled it Cargo.toml)
Add a section to the README to explain that `default-features = false` will be needed on these platforms.
- Rename the Cargo feature "quanta" to "atomic64". - Update the change log and readme. - Update a comment in the yml for GitHub Actions.
Ensure to set num threads to 1 for thread pools when `num_cpus::get()` returns 0.
Support Linux on MIPS and ARMv5TE
CI: Add cross-compile tests for some Linux targets
Restore quanta on 32-bit MIPS and ARMv5TE
Remove quanta from the "Resolving compile errors" section.
Prepare for v0.5.4
Conflicts: CHANGELOG.md Cargo.toml
tatsuya6502
commented
Sep 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes from the following PRs: #39, #40, #42 and #44.