Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settable permissioners / revert reinit #150

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

elmariachi111
Copy link
Member

adds a setter for the permissioner
uses contracts instead of addresses

uses contracts instead of addresses

Signed-off-by: stadolf <stefan@molecule.to>
Signed-off-by: stadolf <stefan@molecule.to>
@elmariachi111 elmariachi111 force-pushed the stefan/feature-eip-1167 branch from 00fa16d to 6324d6d Compare January 10, 2024 18:49
Copy link
Contributor

@polus-arcticus polus-arcticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elmariachi111 elmariachi111 merged commit 6edce47 into feature/eip-1167 Jan 11, 2024
1 check passed
@elmariachi111 elmariachi111 deleted the stefan/feature-eip-1167 branch January 11, 2024 10:41
polus-arcticus pushed a commit that referenced this pull request Jan 11, 2024
* adds a setter for the permissioner
* uses contracts instead of addresses
* adds a address(0) check to setters

Signed-off-by: stadolf <stefan@molecule.to>

---------

Signed-off-by: stadolf <stefan@molecule.to>
elmariachi111 added a commit that referenced this pull request Jan 17, 2024
* adds a setter for the permissioner
* uses contracts instead of addresses
* adds a address(0) check to setters

Signed-off-by: stadolf <stefan@molecule.to>

---------

Signed-off-by: stadolf <stefan@molecule.to>
elmariachi111 pushed a commit that referenced this pull request Jan 17, 2024
readded ignore comment
settable permissioners / revert reinit (#150)

* adds a setter for the permissioner
* uses contracts instead of addresses
* adds a address(0) check to setters

Signed-off-by: stadolf <stefan@molecule.to>

---------

Signed-off-by: stadolf <stefan@molecule.to>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants