Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: move absolute and relative paths to core functionality #362

Merged
merged 10 commits into from
Oct 16, 2023
Merged

v3: move absolute and relative paths to core functionality #362

merged 10 commits into from
Oct 16, 2023

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Oct 13, 2023 •
edited by molefrog
Loading

TODOs:

  • test
  • update types
  • (???)

@jeetiss jeetiss self-assigned this Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/wouter/esm/index.js 1.45 KB (+0.89% 🔺)
packages/wouter/esm/use-browser-location.js 694 B (0%)
packages/wouter/esm/memory-location.js 566 B (0%)
packages/wouter/esm/use-hash-location.js 566 B (0%)
packages/wouter-preact/esm/index.js 852 B (-12.71% 🔽)
packages/wouter-preact/esm/use-browser-location.js 255 B (0%)
packages/wouter-preact/esm/use-hash-location.js 86 B (0%)
packages/wouter-preact/esm/memory-location.js 86 B (0%)

@jeetiss jeetiss changed the title v3; move absolute and relative paths to core functionality v3: move absolute and relative paths to core functionality Oct 13, 2023
@jeetiss jeetiss requested a review from molefrog October 16, 2023 11:17
@jeetiss jeetiss marked this pull request as ready for review October 16, 2023 11:17
molefrog
molefrog approved these changes Oct 16, 2023
View reviewed changes
packages/wouter/src/memory-location.js Outdated Show resolved Hide resolved
packages/wouter/test/use-location.test.tsx
Comment on lines +36 to +37
function createLocationSpec(stub: StubType) {
describe(stub.name, () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would describe.each be helpful here?
https://vitest.dev/api/#describe-each

jeetiss and others added 2 commits October 16, 2023 14:44
@jeetiss @molefrog
Update packages/wouter/src/memory-location.js
7c7fd5f 
Co-authored-by: Alexey Taktarov <molefrog@gmail.com>
@jeetiss
fix code style
b9588bf
@jeetiss jeetiss merged commit 7f5bd92 into v3 Oct 16, 2023
3 checks passed
@jeetiss jeetiss deleted the absolute-relative-refactoring branch October 17, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molefrog molefrog molefrog approved these changes

Assignees

@jeetiss jeetiss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeetiss @molefrog