Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build log: use async with #24

Merged
merged 1 commit into from
Sep 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions molior/molior/queues.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,17 @@ async def buildlog_writer(build_id):
del buildlogs[build_id]
return
try:
afp = AIOFile(filename, 'a')
await afp.open()
writer = Writer(afp)
while True:
msg = await dequeue(buildlogs[build_id])
if msg is None:
await enqueue_backend({"logging_done": build_id})
continue
elif msg is False:
break
await writer(msg)
await afp.fsync()
async with AIOFile(filename, 'a') as afp:
writer = Writer(afp)
while True:
msg = await dequeue(buildlogs[build_id])
if msg is None:
await enqueue_backend({"logging_done": build_id})
continue
elif msg is False:
break
await writer(msg)
await afp.fsync()
except Exception as exc:
logger.exception(exc)

Expand Down