Implement InternalSocket.prototype.writeLatin1String #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent failure with node.js 6.4.0 due to nodejs/node@28071a1
papandreou
added a commit
to unexpectedjs/unexpected-mitm
that referenced
this pull request
Aug 16, 2016
|
Thank you again! Released as v1.3.0. |
|
Thanks :) |
This was referenced Aug 17, 2016
papandreou
added a commit
to unexpectedjs/unexpected-mitm
that referenced
this pull request
Aug 25, 2016
Use req.connection._mitm.{client,opts} instead of trying to keep track of the last hijacked socket and options. Fixes failing test.
|
@vvo, you're welcome ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent failure with node.js 6.4.0 due to
nodejs/node@28071a1
The error I ran into looked like this: https://travis-ci.org/assetgraph/assetgraph/jobs/152717292#L357-L372