Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Order Update Status to WooCommerce default Status. #18

Closed
a3rev opened this issue Jan 7, 2015 · 5 comments
Closed

Change Order Update Status to WooCommerce default Status. #18

a3rev opened this issue Jan 7, 2015 · 5 comments
Assignees

Comments

@a3rev
Copy link

a3rev commented Jan 7, 2015

Hi Guys

We have been contacted by a customer of ours regarding an issue with our Premium plugin WooCommerce Quotes and Orders http://a3rev.com/shop/woocommerce-quotes-and-orders/ that he has installed on his site which has your Mollie Script.

The issue that we are having is that everything works fine except when a Quote request is created (Quotes are created as WooCommerce orders with a custom status 'Quotes' . The admin then edits the order and can send the Order to the customer by email from the order edit panel.

The admin change the order status to 'Payment pending' before sending and the email has a link back to the checkout and the customer can complete the transaction. All of that works fine.

BUT when the checkout use Mollie gateway - or Quotes and Orders plugin generate another email to the customer.

From what we can see this happens because the Mollie script changes the Order status to Processing status.

Our plugin have hook action to 2 ways for send quote email

pending to quote : first email is sent when order (quote request is created)
and
pending to processing :

The WooCommerce default status for order processing is to change status to On-hold and or Completed when the customer has completed the payment transaction.

We have not ever seen a gateway use any other Status other then the WooCommerce defaults.

If you where to update this script from changing the status to 'Processing' to the default status 'On - Hold' of WooCommerce then our 2 plugins could work seamlessly together.

I have sent the customer Thomas a Link to this issue so that he can track it progress.

Happy to fork and submit a patch if you would prefer we do that?

Thank you - Steve

@willemstuursma
Copy link
Contributor

Hi @a3rev,

Thank you for your extensive explanation. I am sorry to hear that our plugin is not playing nice with other plug ins. We would much appreciate a pull request from you for this change.

Let me know if you have any questions or if you need some help.

@willemstuursma willemstuursma self-assigned this Jan 7, 2015
@BureauSpruit
Copy link

Hi Steve and Willem,

Thanks a lot in advance to the both of you. Although it might seem a small issue, it can cause a lot of trouble and misscommunication to customers during the process of ordering.

If you need any information from my side, please let me know.

Kind regards,
Thomas

@a3rev
Copy link
Author

a3rev commented Jan 9, 2015

Hi Willem and Thomas

No need for a patch to be submitted. Furher testing showed the the status is not actually return by this plugin, it is return by Mollie API https://www.mollie.com/nl/

When a payment is processed the API returns status 'open' - but WooCommerce does not support that status and seems to default to the 'Processing Payment' status.

We have made a fix for this behavior in our plugin by adding this patch.

// Fixed resend quote email when payment is Mollie
$isMolliePayment = get_post_meta( $order_id,'_is_mollie_payment' );
if ( $isMolliePayment && 'processing' == $this->object->status ) { return;
}

Thomas we have added that to the plugin on your site and included it in update version 1.2.4 which has some other Tweaks and fixes that you need https://s3.amazonaws.com/a3_plugins/WooCommerce+Quotes+and+Orders+PRO/changelog.txt

Please run that update when you see it in your wp-plugins dashboard. Should be there now.

Willem - this issue can be marked as resolved now

Thank you - Steve

@BureauSpruit
Copy link

Hi Steve,

Many, many, many thanks for the great support. The issue is indeed solved. Much appreciated!
Thanks a lot and enjoy the weekend!

Kind regards,
Thomas

Op 9-1-2015 15:05:39, a3rev notifications@github.com schreef:
Hi Willem and Thomas
No need for a patch to be submitted. Furher testing showed the the status is not actually return by this plugin, it is return by Mollie API https://www.mollie.com/nl/ [https://www.mollie.com/nl/]
When a payment is processed the API returns status 'open' - but WooCommerce does not support that status and seems to default to the 'Processing Payment' status.
We have made a fix for this behavior in our plugin by adding this patch.
// Fixed resend quote email when payment is Mollie $isMolliePayment = get_post_meta( $order_id,'_is_mollie_payment' ); if ( $isMolliePayment && 'processing' == $this->object->status ) { return; }
Thomas we have added that to the plugin on your site and included it in update version 1.2.4 which has some other Tweaks and fixes that you need https://s3.amazonaws.com/a3_plugins/WooCommerce+Quotes+and+Orders+PRO/changelog.txt [https://s3.amazonaws.com/a3_plugins/WooCommerce+Quotes+and+Orders+PRO/changelog.txt]
Please run that update when you see it in your wp-plugins dashboard. Should be there now.
Willem - this issue can be marked as resolved now
Thank you - Steve

Reply to this email directly or view it on GitHub [https://github.com//issues/18#issuecomment-69337643].

@willemstuursma
Copy link
Contributor

Hi @a3rev and @BureauSpruit. Thanks for the updates and resolving this issue. Let us know if we can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants