Merge pull request #363 from mollie/pimm/api-error-cleanup

Cleanup ApiError.
mollie · Sep 10, 2024 · b3cfbff · b3cfbff
2 parents a8d0ed2 + 734f57f
commit b3cfbff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 32 deletions.
diff --git a/src/errors/ApiError.ts b/src/errors/ApiError.ts
@@ -27,36 +27,6 @@ export default class ApiError extends Error {
     Object.defineProperty(this, 'message', { enumerable: true });
   }
 
-  /**
-   * Get the error message
-   *
-   * @since 3.0.0
-   * @deprecated Use `error.message` instead.
-   */
-  public getMessage(): string {
-    return this.message;
-  }
-
-  /**
-   * Get the field name that contains an error
-   *
-   * @since 3.0.0
-   * @deprecated Use `error.field` instead.
-   */
-  public getField(): Maybe<string> {
-    return this.field;
-  }
-
-  /**
-   * Get the API status code
-   *
-   * @since 3.0.0
-   * @deprecated Use `error.statusCode` instead.
-   */
-  public getStatusCode(): Maybe<number> {
-    return this.statusCode;
-  }
-
   /**
    * Get the documentation URL
    *

diff --git a/tests/unit/resources/methods.test.ts b/tests/unit/resources/methods.test.ts
@@ -46,7 +46,7 @@ describe('methods', () => {
           })
           .catch(err => {
             expect(err).toBeInstanceOf(ApiError);
-            expect(err.getMessage()).toEqual(error.detail);
+            expect(err.message).toEqual(error.detail);
           });
       });
     });
@@ -57,7 +57,7 @@ describe('methods', () => {
         return new Promise<void>(resolve => {
           methods.get('foo', {}, (err: any, result) => {
             expect(err).toBeInstanceOf(ApiError);
-            expect(err.getMessage()).toEqual(error.detail);
+            expect(err.message).toEqual(error.detail);
             expect(result).toBeUndefined();
             resolve();
           });