Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profileId and testmode to order creation parameters #176

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add profileId and testmode to order creation parameters #176

merged 1 commit into from
Oct 27, 2020

Conversation

DeMoorJasper
Copy link
Contributor

This PR adds testmode and profileId to CreateParameters for Order.

To ensure this can be used when using Mollie Connect if you're relying on TypeScript to ensure type safety.

@Pimm Pimm self-assigned this Oct 26, 2020
Pimm
Pimm approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@Pimm Pimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jasper!

@Pimm Pimm merged commit 01915dc into mollie:master Oct 27, 2020
@DeMoorJasper DeMoorJasper deleted the patch-1 branch October 27, 2020 17:01
@Pimm Pimm mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pimm Pimm Pimm approved these changes

Assignees

@Pimm Pimm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeMoorJasper @Pimm