Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding embed param to Orders.create method #177

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Adding embed param to Orders.create method #177

merged 5 commits into from
Oct 28, 2020

Conversation

Borales
Copy link
Contributor

@Borales Borales commented Oct 27, 2020

According to the Documentation page - embed query param could be passed to fetch the payment data of the newly created Order.

https://docs.mollie.com/reference/v2/orders-api/create-order#embedding-of-related-resources

Besides that, query param in post method (added here) was not used at all.

@Pimm Pimm self-assigned this Oct 27, 2020
Copy link
Collaborator

@Pimm Pimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Oleksandr. Thank you!

@Borales
Copy link
Contributor Author

Borales commented Oct 27, 2020

@Pimm thanks! do you have any estimated date of release for this fix?

@Pimm
Copy link
Collaborator

Pimm commented Oct 27, 2020

do you have any estimated date of release for this fix?

Some things have been reorganised within Mollie over the past few months. We are still working out administrative matters. This is why things have been slower than we would like.

With that said, I do expect to release a version including your addition this week.

@Borales
Copy link
Contributor Author

Borales commented Oct 27, 2020

@Pimm we're working on Mollie integration for DEITY, and we could really use this fix. Thank you for your answer!

@Pimm Pimm merged commit df9519c into mollie:master Oct 28, 2020
@Borales Borales deleted the order-create-embed branch October 28, 2020 08:42
@Pimm Pimm mentioned this pull request Oct 28, 2020
@Pimm
Copy link
Collaborator

Pimm commented Oct 28, 2020

@Borales Version 3.4.0 has been released, which includes your addition.

Please let me know if you have any further issues, as well as if you have any ideas on how we could make the integration process smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants