added idempotencyKey prop to ApiError #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pimm
reviewed
Nov 30, 2022
Pimm
reviewed
Nov 30, 2022
Pimm
reviewed
Nov 30, 2022
janpaepke
changed the base branch from
pimm+jan/advanced-ik
to
pimm+jan/retry
See #294 (comment). This does introduce one breaking change. mollieClient.profiles.delete gained an argument, which means if you are calling it with a callback, you have to change your code. mollieClient.profiles.delete('id', success => …) becomes mollieClient.profiles.delete('id', {}, success => …). I feel this is so unlikely to affect anyone in the real world ‒ especially since the profiles binder is relatively new ‒ that it can be released as a minor version bump instead of a major one.
janpaepke
force-pushed
the
pimm+jan/advanced-ik
branch
from
474ace8
to
e70e41c
Compare
Pimm
approved these changes
Dec 1, 2022
Pimm
force-pushed
the
pimm+jan/advanced-ik
branch
from
d0dec9a
to
0e68625
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Details see #294 (comment) (Idea 3).
Changes:
idempotencyKeythe parameter list got unreadably longidempotencyKeyfrom config in staticApiError.createFromResponse.ApiErrorasMollieApiErrorfor type-safe checks.