Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added captures as embedded objects to payment #330

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

JoostMollie
Copy link
Contributor

No description provided.

@JoostMollie JoostMollie marked this pull request as ready for review September 8, 2023 09:11
@Pimm
Copy link
Collaborator

Pimm commented Sep 17, 2023

Thanks, @JoostMollie!

We should also change PaymentHelper.getCaptures. It should use the embedded captures if present to prevent unnecessary network access. (I'm OK doing that.)

However, the documentation currently does not mention embedded captures. Is this a new thing? Is it stable?

@Pimm Pimm force-pushed the JoostMollie-Embedded-Captures branch from 94ba867 to 18b1e87 Compare September 17, 2023 15:09
@JoostMollie
Copy link
Contributor Author

Thanks, @JoostMollie!

We should also change PaymentHelper.getCaptures. It should use the embedded captures if present to prevent unnecessary network access. (I'm OK doing that.)

However, the documentation currently does not mention embedded captures. Is this a new thing? Is it stable?

Yes the embedding of captures in a payment is stable. We will update the public docs soon. Our private/beta docs are already updated.

Copy link
Collaborator

@Pimm Pimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then!

@Pimm Pimm merged commit 3761948 into master Sep 20, 2023
4 checks passed
@Pimm Pimm deleted the JoostMollie-Embedded-Captures branch September 20, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants