Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing status type #335

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

casperiv0
Copy link
Contributor

This PR includes::

  • Add missing status field for getting the payment methods.

@janpaepke
Copy link
Collaborator

Hi @casperiv0, I would suggest this to be an enum, similar to PaymentStatus or OrderStatus.
Would you mind updating the pr?

@casperiv0
Copy link
Contributor Author

@janpaepke done!

@janpaepke
Copy link
Collaborator

lgtm

@fjbender @Pimm we should merge this before doing the major release.

Copy link
Collaborator

@edorivai edorivai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edorivai
Copy link
Collaborator

@casperiv0 We've about to issue a major version bump as per #338. Would you be able to update to the newer version once it's cut? Planning to cut this week.

New version will require Node >= 14.

If something is blocking you from updating we could backport to the current major.

@casperiv0
Copy link
Contributor Author

Sure! I'm be able to update to the newer version once it's out. Though, to confirm, you simply mean here: rebase my PR from the master/main branch, right?

@edorivai edorivai merged commit a05bea5 into mollie:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants