-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update required node version [breaking] #341
Conversation
e658296
to
d9d12d0
Compare
d9d12d0
to
7bf9654
Compare
I adjusted the branch protection rules to reflect the pipeline changes. Do you want another review, maybe from @Pimm ? |
Hi @Pimm is it possible for you to review this change? |
Hi @janpaepke this update is showing up as a vulnerability for one of our important integrations, could we skip a second review and merge together with #338 (comment)? |
As @Pimm has been the primary maintainer for a long time I would feel more comfortable with him taking a look. It's not so much about the implementation, but there might be unforeseen side effects implied by a node version bump, which only he might know. I also know that he's a bit preoccupied at the moment. But I'll reach out directly and try to point him towards this. |
@janpaepke understood, since we're getting a bit pressured on time I'll appreciate an update whenever you talk to Pimm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standing in for @Pimm as he's out sick at the moment. This PR looks good. Changes seem safe; only changing Node versions for test runs. Double checked in test output that all steps are using the intended Node version.
This one is good to go!
In accordance with the discussion here, this raises the minimum node version for the package to node 14.
It also updates some github actions versions (which should have no effect).
The CI is now also configured to run on node 20.
This update will require the repo settings to be updated to expect the correct checks.