Display MayHaveMessagesNotification on push with locked db #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
reviewed
Nov 12, 2023
| @@ -28,6 +28,10 @@ public class FcmReceiveService extends FirebaseMessagingService { | |||
| @Override | |||
| public void onMessageReceived(RemoteMessage remoteMessage) { | |||
| if (KeyCachingService.isLocked()) { | |||
| if (remoteMessage != null && remoteMessage.getPriority() == RemoteMessage.PRIORITY_HIGH) { | |||
| Log.d(TAG, "New urgent message received while the db is locked"); | |||
There was a problem hiding this comment.
Suggested change
| Log.d(TAG, "New urgent message received while the db is locked"); | |
| Log.d(TAG, "New high priority message received while the database is locked"); |
|
Thanks for you review. For information, urgent is a signal term which is converted by the server to FCM term.
I've done this for UnifiedPush too : mollyim@9f9d882 but it requires the version 1.1.0 of mollysocket I will publish during the day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works with FCM : If the remote message's priority is high, then the push notification should require a notification :)