Skip to content

Commit

Permalink
Merge pull request #3 from molnarmark/fix/windows
Browse files Browse the repository at this point in the history
Plugin fixed on Windows
  • Loading branch information
molnarmark authored Jun 11, 2021
2 parents 3308e18 + cea3b83 commit 7c84e71
Showing 1 changed file with 26 additions and 11 deletions.
37 changes: 26 additions & 11 deletions plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
SERVER_BINARY_PATH
)

# handling windows
if os.name == "nt":
PLUGIN_NODE_PATH = SERVER_BINARY_PATH

SERVER_PROCESS = None
RUNNING_ON_PORT = None

Expand Down Expand Up @@ -43,21 +47,32 @@ def run(self, edit):
'--wait={}'.format(settings.get('wait')),
]

if (settings.get("browser") != "default"):
if (settings.get('browser') != 'default'):
args.append('--browser={}'.format(settings.get('browser')))

if (settings.get("nobrowser") == True):
if settings.get('nobrowser'):
args.append('--no-browser')

live_server_path = settings.get('global_node_modules_path') + PLUGIN_NODE_PATH
SERVER_PROCESS = subprocess.Popen(
[settings.get('node_executable_path'), live_server_path, project_path] + args,
stdout=subprocess.PIPE,
stdin=subprocess.PIPE,
stderr=subprocess.PIPE,
env=os.environ.copy(),
startupinfo=None,
)
live_server_path = os.path.normpath(settings.get('global_node_modules_path') + PLUGIN_NODE_PATH)
if os.name == 'nt':
SERVER_PROCESS = subprocess.Popen(
[settings.get('node_executable_path'), live_server_path, project_path] + args,
stdout=subprocess.PIPE,
stdin=subprocess.PIPE,
stderr=subprocess.PIPE,
env=os.environ.copy(),
creationflags=0x08000000,
startupinfo=None,
)
else:
SERVER_PROCESS = subprocess.Popen(
[settings.get('node_executable_path'), live_server_path, project_path] + args,
stdout=subprocess.PIPE,
stdin=subprocess.PIPE,
stderr=subprocess.PIPE,
env=os.environ.copy(),
startupinfo=None,
)

RUNNING_ON_PORT = settings.get('port')

Expand Down

0 comments on commit 7c84e71

Please sign in to comment.