Models UnitTest Error.

[Dhuck]

Hi,

i'm trying to run unit test for "models" but I am receiving the following error.

$ python -m unittest tests/testModels.py
Traceback (most recent call last):
  File "/usr/lib64/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/usr/lib64/python3.8/unittest/__main__.py", line 18, in <module>
    main(module=None)
  File "/usr/lib64/python3.8/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/lib64/python3.8/unittest/main.py", line 147, in parseArgs
    self.createTests()
  File "/usr/lib64/python3.8/unittest/main.py", line 158, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames,
  File "/usr/lib64/python3.8/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib64/python3.8/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib64/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/home/vagrant/projects/RootTheBox/tests/testModels.py", line 9, in <module>
    from models import dbsession
  File "/home/vagrant/projects/RootTheBox/models/__init__.py", line 35, in <module>
    if options.log_sql:
  File "/home/vagrant/.local/share/virtualenvs/RootTheBox-hkgRnGAZ/lib/python3.8/site-packages/tornado/options.py", line 145, in __getattr__
    raise AttributeError("Unrecognized option %r" % name)
AttributeError: Unrecognized option 'log-sql'

I have the configuration file and I can to start RTB without problems.

$ cat files/rootthebox.cfg
[Database]
sql_dialect = "sqlite"
sql_database = "rootthebox"
sql_host = "127.0.0.1"
sql_port = 3306
sql_user = ""
sql_password = ""
log_sql = True

Can you help me please or is there another way to run it?

[eljeffeg]

Thanks for pointing this out. I'll work on exposing the unit tests via an run option, but there is still some work that needs to be done as these haven't been kept up and are not py3 tested.

[eljeffeg]

I pushed an update d9fe262 that exposes the unit tests to a command line argument. The Handler tests are not yet Python 3 compliant (still trying to figure out a callback issue), but it should work on Python 2, with the exception of 1 failure that still needs to be worked out. It's an issue with the unit test (likely memcached), not the app itself.

$ python rootthebox.py --tests

[eljeffeg]

Updated the Handler tests for Py3 compatibility. We still have that one failure on the /login test, which I haven't figured out.