Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Escape key change focus #11

Closed
vinsworldcom opened this issue Sep 23, 2022 · 3 comments
Closed

Feature Request - Escape key change focus #11

vinsworldcom opened this issue Sep 23, 2022 · 3 comments

Comments

@vinsworldcom
Copy link

Many Notepad++ docking panels allow pressing the Escape key to switch focus back to the Scintilla editing component (the buffer where you enter your text in "new-1" tabs ...)

Can this be implemented for your docking panel as well?

Cheers.

molsonkiko added a commit that referenced this issue Sep 24, 2022
ADDED
1. `Refresh` button for resetting the form with the JSON in the currently active buffer (resolves Issue #13).
2. __Tree view enhancements__ (resolves Issue #10):
	- Clicking on a tree node to expand it also changes the displayed node path and snaps the caret.
	- `Tab` can be used to switch between controls on the tree form.
	- Drop-down menu option for expanding/collapsing all subtrees when right-clicking on a tree node.
	- Query box is auto-selected when tree is opened.
	- `Ctrl+Enter` while query box is selected submits the query.
	- `Enter` while any button selected is equivalent to clicking it.
	- `Enter` while tree is selected toggles the selected node between expanded/collapsed.
	- `Escape` key takes focus from the tree back to the text editor (resolves Issue #11).

CHANGED
1. Minimizing the tree view closes it completely.
@vinsworldcom
Copy link
Author

vinsworldcom commented Sep 26, 2022

Seems to work fine, but when the selection is in the tree view, Escape sets focus to the Scintilla editing component as desired, but there is an audible system 'bell'.

Maybe similar to: https://stackoverflow.com/questions/6290967/stop-the-ding-when-pressing-enter
??

@molsonkiko
Copy link
Owner

molsonkiko commented Sep 26, 2022

Thanks for bringing this up - this is shockingly difficult to deal with for TreeView controls specifically. I looked at that same StackOverflow thread and tried literally every single one of the suggestions simultaneously, plus the solutions suggested in https://stackoverflow.com/questions/10328103/c-sharp-winforms-how-to-stop-ding-sound-in-treeview. Nothing works. I've successfully stomped out bell sounds from everything else in the application, but the TreeView really wants to teach the world to ding. As you've no doubt noticed (referenced in #10), the dinging happens for Tab, Enter, and Escape, and my attempted fixes haven't changed this.

:(

I'm not saying I'll never solve this problem, but it's looking pretty grim.

molsonkiko added a commit that referenced this issue Sep 26, 2022
Major update to docs to bring up to date with current project.
FIXED
1. Annoying dinging sounds when pressing `Enter`, `Tab`, or `Escape` with the forms.
    Dinging sounds seem impossible to remove from the `TreeView` control
    (see #11), but I will keep trying.
2. Removed some unnecessary imports to simplify code.
molsonkiko added a commit that referenced this issue Sep 28, 2022
ADDED
1. Hotkeys for performing plugin commands when the `Plugins->JsonTools` submenu is open (resolve #14)
2. `to_records` [RemesPath function](/docs/RemesPath.md#non-vectorized-functions) for converting JSON to an array of objects. This essentially gives a JSON document with the same contents as the CSV file generated by the JSON to CSV form.
3. `pivot` [RemesPath function](/docs/RemesPath.md#non-vectorized-functions) for taking long data and pivoting it into wide data.
4. Benchmark test for floating-point arithmetic. Currently Remespath appears to be somewhat slower than Pandas (with default column dtypes) for string operations and faster for floating-point arithmetic.

FIXED
1. Annoying dinging sounds when pressing `Enter`, `Tab`, or `Escape` with the forms. Dinging sounds seem impossible to remove from the `TreeView` control (see #11), but I will keep trying.
2. Make sure that changes to settings are propagated to the `JSON from files and APIs` form if it exists.
3. More useful error messages from RemesPath.
4. `JSON from files and APIs` form's resources are disposed at cleanup.
molsonkiko added a commit that referenced this issue Mar 23, 2023
fix issues #10 and #11 (system bell on tree view)
Address (hopefully) issue #12 (text cutoff)
@molsonkiko
Copy link
Owner

The problem was between the keyboard and chair the whole time! 😝
I was trying to suppress all those keypresses on KeyUp, after the user had already pressed the key!
Now the suppression happens on KeyDown, and my users can enjoy blessed silence while working with my tree view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants