Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List entities example #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

List entities example #11

wants to merge 5 commits into from

Conversation

Simard302
Copy link
Collaborator

Overview

This PR creates a new example for inspecting a new structure and listing many of its entities and their properties.

Changes made

  • Created inspect example "list_entities"
    • Count the number of waters
    • Retrieve the names and residue codes for all covalent ligands
    • Count the number of AltLoc positions
    • Retrieve the names and chains of all polymer entities

How to test

Ensure the names and counts of all the properties are correct for multiple PDBs

  • By default, uses 1PTH (which has many of these)
  • Can edit the PDB in the code

Specific review requests

For each of the examples:

  • Are there enough comments to sufficiently describe the process?
  • Are the comments accurately describing the process?
  • Are there any anti-patterns in the examples?
  • Can the examples be more efficient?

@Simard302 Simard302 requested a review from papillot June 11, 2024 14:01
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
inspect/list_entities/src/index.ts Outdated Show resolved Hide resolved
@Simard302 Simard302 requested a review from papillot June 12, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants