Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submeso scale smoothing #264

Open
aidanheerdegen opened this issue Dec 11, 2018 · 2 comments
Open

Fix submeso scale smoothing #264

aidanheerdegen opened this issue Dec 11, 2018 · 2 comments

Comments

@aidanheerdegen
Copy link
Contributor

Grid scale noise observed in the ACCESS-OM2 models (COSIMA/access-om2#110) could be addressed if the smooth_hblt option was fixed.

!  <DATA NAME="smooth_hblt" TYPE="logical">
!  For smoothing on the submeso bldepth field. This is useful 
!  since the bldepth obtained from KPP or diagnosed mld can 
!  have some grid noise. 
!  Default smooth_hblt=.false. since this agrees with legacy.
!  Note that this scheme fails to reproduce across
!  processor layout, so it remains broken.  
!  </DATA> 

https://github.com/mom-ocean/MOM5/blob/master/src/mom5/ocean_param/lateral/ocean_submesoscale.F90#L1330

@russfiedler
Copy link
Collaborator

To expand on this. It appears that the smoothing as it stands allows the the boundary layer depth to be smoothed to below the maximum depth of the water column if the surrounding values of hblt are large enough. It appears that subsequent code assumes that the value of hblt is sensible when calculating kblt etc. There should be a sanity check for the value, something like hblt=min(hblt,zbot) where zbot is the depth of the column.

@StephenGriffies
Copy link
Contributor

I agree @russfiedler ; sanity check is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants