Fix smoothing of hblt and eliminate unessary domain updates #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not game to change this until proven otherwise? |
|
If we have a test for for the submesoscale restratification let's turn on the smoothing (only need to smooth once) and see if it reproduces across layouts. |
|
@russfiedler It was Chris Chapman who first noticed it right? Can he suggest a run, or even better, actually do the test? Many hands make light work and all that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Horizontal smoothing could force
hbltto be deeper than column depth. Enforce a limit.Spurious masking of smoothed
hbltto the North removed.Eliminated some redundant domain updates.
#264