Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix halo bug on tidal forcing #324

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

adele-morrison
Copy link
Contributor

Fixes the bugs in the tidal forcing mentioned here #323. Thanks to @russfiedler.

Copy link
Collaborator

@russfiedler russfiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note, eta_eq_tidal is defined on the (possibly) extended halo grid. There are no problems if using legacy halos.

@aekiss
Copy link
Collaborator

aekiss commented Oct 23, 2020

@russfiedler I'm happy to merge this - any objections?

@russfiedler
Copy link
Collaborator

Go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants