Skip to content

Commit

Permalink
Fix for nonzero remapped vertical diffusion tendencies
Browse files Browse the repository at this point in the history
As raised in NOAA-GFDL/MOM6-examples#162,
column integrals of the vertical diffusive tendences did not sum to zero
when remapped from the model's native coordinate. Another call to
diag_update_remap_grids was added after the call to
applyBoundaryFluxesInOut (which changes the layer thicknesses due to
freshwater fluxes) and the checks for negative thickness.
  • Loading branch information
Andrew Shao committed Sep 20, 2017
1 parent 3d60b91 commit a972015
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/parameterizations/vertical/MOM_diabatic_driver.F90
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,9 @@ subroutine diabatic(u, v, h, tv, Hml, fluxes, visc, ADp, CDp, dt, G, GV, CS)
endif
enddo ; enddo
enddo
! Application of boundary forcing and the checks for negative thickness may have changed layer thicknesses
call diag_update_remap_grids(CS%diag)

if (CS%debug) then
call MOM_state_chksum("after negative check ", u, v, h, G, GV, haloshift=0)
call MOM_forcing_chksum("after negative check ", fluxes, G, haloshift=0)
Expand Down

0 comments on commit a972015

Please sign in to comment.