-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test diagnostics and diag system #147
Comments
IntroductionPresently the model is tested for regressions by comparing checksums of key values between code changes. This allows scientific changes to be detected and then verified. The outputs of the model are not tested. In particular this means that incorrect calculation of diagnostic outputs will go unnoticed. The purpose of this task is to support testing of diagnostics. One motivation to do this now is so that changes to the diagnostic manager within MOM can be made. This task will introduce three kinds of system-level tests: Requirements
DesignSteps: This process is generic, i.e. it is not tied to a particular test case. It could be repeated for several test cases until we know that we've covered absolutely all the diagnostics in the source code. Presently it only runs on the ice_ocean_SIS2/Baltic test. ImplementationSee MOM-examples/test/test_diagnostic_output.py Presently, in order to run the tests a GNU repro executable should already exist. Then run:
On gaea is may be necessary to do |
" This reverts commit 3440869.
- NOAA-GFDL/SIS2@66d58c3 Merge branch 'nicjhan-diagnostic-tests' into dev/master - NOAA-GFDL/SIS2@0b468a2 Revert "Call diag_mediator_end() to close open files. mom-ocean/MOM6#147" - NOAA-GFDL/SIS2@620e355 Increase the maximum diagnostics to allow exhaustive diagnostic checking. - NOAA-GFDL/SIS2@41812db Fix diagnostic tmp array shape. mom-ocean/MOM6#147 - NOAA-GFDL/SIS2@3440869 Call diag_mediator_end() to close open files. mom-ocean/MOM6#147 - NOAA-GFDL/SIS2@4d80387 Array shape mismatches for ice SW diagnostics. Closes #17.
- mom-ocean/MOM6@599379a Only call diag_manager_end() in solo mode - NOAA-GFDL/SIS2@6a26cd1 Call diag_mediator_end() to close open files. mom-ocean/MOM6#147 - NOAA-GFDL/SIS2@16d0be6 Removed call to diag_manager_end()
- 08367b4 Merge branch 'nicjhan-diagnostic-tests' into dev/master - 958789e Removing latent_evap from list of obsolete diagnostics - b9a23f4 Revert "Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155" - 9d03ff3 Merge branch 'diagnostic-tests' of github.com:nicjhan/NOAA-GFDL-MOM6 into nicjhan-diagnostic-tests - ad474f4 Maximum number of diagnostics increased in order to do exhaustive diagnostic checking. mom-ocean#147. - 7f5cc91 Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155 - c464f2d Only register N2, S2 diagnostics when the configuration supports them. mom-ocean#147 - b1ae675 Bugfix: Fl_itidal diagnostic shape incorrect. Closes mom-ocean#151 - 568c54c Call diag_mediator_end to close open files. Closes mom-ocean#156
$ py.test Or if you don't have py.test installed: $ python tests/runtests.py Asl use --help, paying particular attention to the 'custom options' section. See CommerceGov/NOAA-GFDL-MOM6/mom-ocean#147.
Add option to control Biharmonic coeff. via grid Reynolds number
Ice ridging from Icepack
Issue #62 will result in some changes to the diagnostic infrastructure. Before doing this we need a way to test the diagnostics to ensure that no regressions are introduced. Tests for diagnostic output would be very useful for other reasons also.
Three kinds of tests are proposed:
The text was updated successfully, but these errors were encountered: