Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mom6/examples/coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/INPUT is incomplete #49

Closed
nikizadehgfdl opened this issue Sep 12, 2014 · 5 comments

Comments

@nikizadehgfdl
Copy link
Contributor

It is missing many input files for ATM. Tests won't run:

FATAL from PE 26: mg_drag_init: source_of_sgsmtn="computed", but topography data file does not exist

@adcroft
Copy link
Collaborator

adcroft commented Sep 12, 2014

It's working for me. Is this XML-driven? Any idea what file is missing. I'm guessing it might be this file but I'm not sure since it's out of our usual domain...
lrwxrwxrwx 1 Alistair.Adcroft gfdl_O 58 2014-03-07 13:12 mg_drag.res.nc -> .datasets/AM2_LM3_MOM6i_1deg/tikal/1990_ICs/mg_drag.res.nc

@nikizadehgfdl
Copy link
Contributor Author

When I list that INPUT I get the following. There seems to be a lot of files missing, not just mg_drag.res.nc, e.g., cns_*.nc What do you get?

t1-batch2: /lustre/f1/Niki.Zadeh/testing_20140911_mom6_20140911/FMS_compile_libs/src/mom6/examples/coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/INPUT % ls
aerosol.optical.dat        eftsw4str                 ground_type_field                 h2ocoeff_ckd_0_3000_10cm_hi00      id1o3                         o39001200_hi92_data
annual_mean_ozone          esf_sw_input_data_n38b18  groundwater_residence_time_field  h2ocoeff_ckd_speccombwidebds_hi00  id2h2obdckd2p1                radfn_5-2995_100-490k
BetaDistributionTable.txt  esf_sw_input_data_n72b25  h2o12001400_hi00_data             h2ocoeff_ckd_speccombwidebds_hi92  id2h2obdfull                  randelo3data
ch4_gblannualdata          f113_gblannualdata        h2o12001400_hi92_data             h2ocoeff_rsb_0_3000_10cm_hi00      id2h2orbts                    river_destination_field
co2_gblannualdata          f11_gblannualdata         h2ockd2.1_corrdata                h2ocoeff_rsb_speccombwidebds_hi00  lean_solar_spectral_data.dat  seasonal_ozone
coupler.res                f12_gblannualdata         h2ockd2.1_data                    h2ocoeff_rsb_speccombwidebds_hi92  n2o_gblannualdata             stdlvls
cover_type_field           f22_gblannualdata         h2ockd2.4_corrdata                id1ch4n2                           o39001200_hi00_data           swstratendramadata

@adcroft
Copy link
Collaborator

adcroft commented Sep 12, 2014

The files are listed under https://github.com/CommerceGov/NOAA-GFDL-MOM6/tree/dev/master/examples/coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/INPUT

It's areal shame that FRE doesn't let you do a wild-card.

FWIW here is my ls examples/coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/INPUT/. I don't know if they are all needed but we have needed them at some point for some model...

aerosol.climatology.nc                    cns_1320_490630.nc    cns_310_12001400.nc  cns_4000_12001400.nc       f11_gblannualdata                  ice_model.res.nc                         radfn_5-2995_100-490k
aerosol.optical.dat                       cns_1320_490850.nc    cns_310_560630.nc    cns_500_10701200.nc        f12_gblannualdata                  id1ch4n2                                 radiation_driver.res.nc
albedo.data.nc                            cns_1320_630700.nc    cns_330_43um.nc      cns_500_12001400.nc        f22_gblannualdata                  id1o3                                    radiative_gases.res.nc
amip1_sst.data.nc                         cns_1320_700850.nc    cns_330_490630.nc    cns_500_560630.nc          fv_rst.res.nc                      id2h2obdckd2p1                           randelo3data
annual_mean_ozone                         cns_165_43um.nc       cns_330_490850.nc    cns_600_43um.nc            fv_srf_wnd.res.nc                  id2h2obdfull                             reynolds_sst.data.nc
asmsw_data.nc                             cns_165_490630.nc     cns_330_630700.nc    cns_600_490630.nc          geohydrology.nc                    id2h2orbts                               reyoi_sst.data.nc
atmos_coupled.res.nc                      cns_165_490850.nc     cns_330_700850.nc    cns_600_490850.nc          geohydrology_table.nc              lake.res.nc                              river_data.nc
atmos_hgrid.nc                            cns_165_630700.nc     cns_340_10701200.nc  cns_600_630700.nc          geothermal_heating_cm2g.nc         land_hgrid.nc                            river_destination_field
atmos_mosaic.nc                           cns_165_700850.nc     cns_340_12001400.nc  cns_600_700850.nc          glac.res.nc                        land_mask.nc                             river.res.nc
atmos_mosaic_tile1Xland_mosaic_tile1.nc   cns_1750_12001400.nc  cns_340_560630.nc    cns_660_43um.nc            GOLD_IC.2010.11.15.nc              land_mosaic.nc                           salt_restore.nc
atmos_mosaic_tile1Xocean_mosaic_tile1.nc  cns_180_10701200.nc   cns_348_43um.nc      cns_660_490630.nc          GOLD_IC_L63.12.19.2008.nc          land_mosaic_tile1Xocean_mosaic_tile1.nc  seasonal_ozone
atmos_tracers.res.nc                      cns_180_12001400.nc   cns_348_490630.nc    cns_660_490850.nc          GOLD.res.nc                        land.res.nc                              seawifs_1998-2006_GOLD_smoothed_2X.nc
basin.nc                                  cns_180_560630.nc     cns_348_490850.nc    cns_660_630700.nc          grid_spec.nc                       lean_solar_spectral_data.dat             sgs_h2.nc
BetaDistributionTable.txt                 cns_2250_12001400.nc  cns_348_630700.nc    cns_660_700850.nc          ground_type_field                  mg_drag.res.nc                           snow.res.nc
cana.res.nc                               cns_275_10701200.nc   cns_348_700850.nc    cns_700_12001400.nc        ground_type.nc                     mosaic.nc                                soil_brdf.nc
cfc.bc.nc                                 cns_275_12001400.nc   cns_356_43um.nc      co2_gblannualdata          groundwater_residence_time_field   n2o_gblannualdata                        soil.res.nc
ch4_gblannualdata                         cns_275_560630.nc     cns_356_490630.nc    conc_all.nc                gustiness_qscat.nc                 navy_topography.data.nc                  sst_ice_clim.nc
clim_CHL_esm2g_yrs_201-360.nc             cns_2800_12001400.nc  cns_356_490850.nc    coupler.res                h2o12001400_hi00_data              o39001200_hi00_data                      stdlvls
cns_0_10701200.nc                         cns_280_10701200.nc   cns_356_630700.nc    cover_type_field           h2o12001400_hi92_data              o39001200_hi92_data                      strat_cloud.res.nc
cns_0_12001400.nc                         cns_280_12001400.nc   cns_356_700850.nc    cover_type_field.nc        h2ockd2.1_corrdata                 o3.climatology.nc                        swstratendramadata
cns_0_43um.nc                             cns_280_560630.nc     cns_360_43um.nc      cover_type.nc              h2ockd2.1_data                     ocean_grid.7.29.2008_fixed.nc            temp_restore.nc
cns_0_490630.nc                           cns_300_12001400.nc   cns_360_490630.nc    eftsw4str                  h2ockd2.4_corrdata                 ocean_hgrid.nc                           tideamp.nc
cns_0_490850.nc                           cns_300_43um.nc       cns_360_490850.nc    emissions.ch3i.GEOS4x5.nc  h2ocoeff_ckd_0_3000_10cm_hi00      ocean_mask.nc                            topog.nc
cns_0_560630.nc                           cns_300_490630.nc     cns_360_630700.nc    esf_sw_input_data_n38b18   h2ocoeff_ckd_speccombwidebds_hi00  ocean_mosaic.nc                          vegn1.res.nc
cns_0_630700.nc                           cns_300_490850.nc     cns_360_700850.nc    esf_sw_input_data_n72b25   h2ocoeff_ckd_speccombwidebds_hi92  ocean_vgrid.nc                           vegn2.res.nc
cns_0_700850.nc                           cns_300_630700.nc     cns_375_10701200.nc  extlw_data.nc              h2ocoeff_rsb_0_3000_10cm_hi00      OM3_zgrid.nc                             WOA05_pottemp_salt.nc
cns_1250_12001400.nc                      cns_300_700850.nc     cns_375_12001400.nc  extsw_data.nc              h2ocoeff_rsb_speccombwidebds_hi00  omgsw_data.nc                            zonal_ozone_data.nc
cns_1320_43um.nc                          cns_310_10701200.nc   cns_375_560630.nc    f113_gblannualdata         h2ocoeff_rsb_speccombwidebds_hi92  physics_driver.res.nc

@nikizadehgfdl
Copy link
Contributor Author

This has nothing to do with FRE. Here's the procedure to reproduce:

gaea6: /ncrc/home2/Niki.Zadeh % git clone --recursive git@github.com:CommerceGov/NOAA-GFDL-MOM6.git
Cloning into 'NOAA-GFDL-MOM6'...
remote: Counting objects: 24787, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 24787 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (24787/24787), 27.45 MiB | 5.18 MiB/s, done.
Resolving deltas: 100% (16977/16977), done.
Checking connectivity... done
Checking out files: 100% (2118/2118), done.
Submodule 'pkg/CVMix-src' (https://github.com/CVMix/CVMix-src.git) registered for path 'pkg/CVMix-src'
Submodule 'tools/matlab/gtools' (https://github.com/Adcroft/gtools.git) registered for path 'tools/matlab/gtools'
Submodule 'tools/python/025gridGeneration/MIDAS' (https://github.com/mjharriso/MIDAS.git) registered for path 'tools/python/025gridGeneration/MIDAS'
Cloning into 'pkg/CVMix-src'...
remote: Counting objects: 2526, done.
remote: Total 2526 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (2526/2526), 4.30 MiB | 0 bytes/s, done.
Resolving deltas: 100% (1816/1816), done.
Checking connectivity... done
Submodule path 'pkg/CVMix-src': checked out '0f781a27094c151f1367e362c8b603795c2e80a3'
Cloning into 'tools/matlab/gtools'...
remote: Counting objects: 42, done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 42 (delta 11), reused 40 (delta 10)
Unpacking objects: 100% (42/42), done.
Checking connectivity... done
Submodule path 'tools/matlab/gtools': checked out 'da62c575154a5a0a16993656a6951a0f35c0fc07'
Cloning into 'tools/python/025gridGeneration/MIDAS'...
remote: Counting objects: 602, done.
remote: Total 602 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (602/602), 1.44 MiB | 0 bytes/s, done.
Resolving deltas: 100% (345/345), done.
Checking connectivity... done
Submodule path 'tools/python/025gridGeneration/MIDAS': checked out '1ca9a60b0df121c839a9f85cfba60dcaf944b19c'

gaea6: /ncrc/home2/Niki.Zadeh % ls NOAA-GFDL-MOM6/examples/coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/INPUT/
aerosol.optical.dat        eftsw4str                 ground_type_field                 h2ocoeff_ckd_0_3000_10cm_hi00      id1o3                         o39001200_hi92_data
annual_mean_ozone          esf_sw_input_data_n38b18  groundwater_residence_time_field  h2ocoeff_ckd_speccombwidebds_hi00  id2h2obdckd2p1                radfn_5-2995_100-490k
BetaDistributionTable.txt  esf_sw_input_data_n72b25  h2o12001400_hi00_data             h2ocoeff_ckd_speccombwidebds_hi92  id2h2obdfull                  randelo3data
ch4_gblannualdata          f113_gblannualdata        h2o12001400_hi92_data             h2ocoeff_rsb_0_3000_10cm_hi00      id2h2orbts                    river_destination_field
co2_gblannualdata          f11_gblannualdata         h2ockd2.1_corrdata                h2ocoeff_rsb_speccombwidebds_hi00  lean_solar_spectral_data.dat  seasonal_ozone
coupler.res                f12_gblannualdata         h2ockd2.1_data                    h2ocoeff_rsb_speccombwidebds_hi92  n2o_gblannualdata             stdlvls
cover_type_field           f22_gblannualdata         h2ockd2.4_corrdata                id1ch4n2                           o39001200_hi00_data           swstratendramadata
gaea6: /ncrc/home2/Niki.Zadeh % 

@adcroft
Copy link
Collaborator

adcroft commented Sep 12, 2014

@nikizadehgfdl you're correct; the INPUT/ directory is incomplete in the repository even though @Hallberg-NOAA and I both have complete directories. I think the cause can be traced back to the .gitignore created in the first commit of the repo which has a *.nc in it. We were still learning at that point.

Ironically, commit e11a83f (from March) was explicitly trying to fix this setup but evidently I failed to test it properly.

I'll fix the .gitignore first (which shouldn't be so inclusive) and then sort out the INPUT directory.

adcroft added a commit that referenced this issue Sep 17, 2014
- Issue #49 root cause can be traced to a global *.nc in the
  top-level .gitignore which hides inconsistency in the INPUT/
  directory.
- Added comments to .gitignore
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
…d_analysis_edits

Layer ave T&S to diag_table; sea ice analysis mod
gustavo-marques added a commit to gustavo-marques/MOM6 that referenced this issue Apr 19, 2018
SMoorthi-emc pushed a commit to SMoorthi-emc/MOM6 that referenced this issue Jan 18, 2021
…s_in_nupoc

Add two halo updates for taux and tauy in mom_surface_forcing_nuopc
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this issue Jun 15, 2021
- This is a simple fix for issue mom-ocean#49
- 1st issue
  The crash in prod+openmp mode comes from a non-thread-safe subroutine call from within an OMP PARALLEL DO region.
  The offending subroutine calls are advect_tracers_thicker() in ice_transport.F90.
  This subroutine has a pointer inside (Tr) that could change unexpectedly from underneath a thread depending on an input argument.
  The easy way to bypass the issue is to put the subroutine calls inside a OMP CRITICAL section (see below) which forces the threads
  to pass through one at a time. Of course this is not the efficient way to fix the issue.
  For an efficient fix we need to change the way the subroutine uses the pointer (Tr).
- 2nd issue
  The crash with debug + openmp comes from another non-thread-safe block of code that allocates
  some arrays inside a OMP parallel region in SIS_slow_thermo.F90.
  The fix is to protect the block with the $OMP SINGLE clause to let only one thread to pass through
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Jan 24, 2022
  Renamed the framework module MOM_scaling_check.F90 to MOM_unique_scales.F90 to
help differentiate it from MOM_check_scaling.F90, and renamed the subroutine
check_scaling_factors() as check_scaling_uniqueness().  Also added
_Dimensional_consistency.dox to describe the dimensional consistency testing.
This commit should address the issues raised in the review of MOM6 PR mom-ocean#49.  All
answers and output are bitwise identical.
marshallward pushed a commit to Hallberg-NOAA/MOM6 that referenced this issue Feb 16, 2022
  Renamed the framework module MOM_scaling_check.F90 to MOM_unique_scales.F90 to
help differentiate it from MOM_check_scaling.F90, and renamed the subroutine
check_scaling_factors() as check_scaling_uniqueness().  Also added
_Dimensional_consistency.dox to describe the dimensional consistency testing.
This commit should address the issues raised in the review of MOM6 PR mom-ocean#49.  All
answers and output are bitwise identical.
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this issue Aug 16, 2022
Remove logic to get and set CPU affinity for Darwin (MacOSX) platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants