Removes missing_value argument from fns in MOM_diag_remap #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adcroft
commented
Apr 16, 2020
adcroft
commented
- This is a very small step towards Remove missing_value from MOM6 code #769. When I looked at what it will take to deal with Remove missing_value from MOM6 code #769 it turns out diag_mediator needs a significant refactor that just isn't going to happen overnight.
- missing_value was an argument to several functions in MOM_diag_remap but was not used. At one point these functions incorrectly used missing_value to mask data but this is not the correct usage of missing_value nor the right way to do masking in MOM6. This was fixed 3 years ago and this commit simply removes unused arguments.
- missing_value was a argument to several functions in MOM_diag_remap but was not used. At one point these functions incorrectly used missing_value to mask data but this is not the correct usage of missing_value not the right way to use masking in MOM6. This was fixed 3 years ago and this commit simply removes unused arguments.
|
There are conflicts in this PR now, can you take a look when you get a chance? |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1091 +/- ##
============================================
- Coverage 45.80% 41.27% -4.53%
============================================
Files 215 215
Lines 69480 69480
============================================
- Hits 31822 28679 -3143
- Misses 37658 40801 +3143
Continue to review full report at Codecov.
|
|
I resolved the commit in the GitHub editor, but obviously it has now not been tested locally. Would be good for you to review it if you get a chance. |
|
Gaea regression testing: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10237 No regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.