Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROTATE_INDEX, INDEX_TURNS moved to debug params #1097

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

marshallward
Copy link
Collaborator

The index rotation flags were incorrectly handled as model parameters,
rather than debug parameters. This patch fixes this oversight.

The index rotation flags were incorrectly handled as model parameters,
rather than debug parameters.  This patch fixes this oversight.
@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #1097 into dev/gfdl will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1097   +/-   ##
=========================================
  Coverage     45.79%   45.79%           
=========================================
  Files           215      215           
  Lines         69484    69484           
=========================================
  Hits          31819    31819           
  Misses        37665    37665           
Impacted Files Coverage Δ
src/core/MOM_barotropic.F90 70.80% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf.F90 0.00% <0.00%> (ø)
src/ice_shelf/MOM_marine_ice.F90 0.00% <0.00%> (ø)
src/core/MOM_forcing_type.F90 62.88% <33.33%> (ø)
src/core/MOM.F90 66.33% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40162d1...c4ae4b9. Read the comment docs.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these changes are the right thing to do. Because the MOM_parameter_doc files will change, there will have to be a manual update to MOM6-examples, but these are simple enough that I think we should consider doing it simulaneously with one of the other contemporaneous merges that also has changes to these files.

@marshallward
Copy link
Collaborator Author

Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10294

Regression has passed (excluding parameter verification)

@Hallberg-NOAA Hallberg-NOAA merged commit dee0420 into mom-ocean:dev/gfdl Apr 29, 2020
@marshallward marshallward deleted the cp_dims branch September 2, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants