Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remapped diagnostic documentation #1098

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Conversation

angus-g
Copy link
Collaborator

@angus-g angus-g commented Apr 29, 2020

Hopefully I'm not misremembering/misunderstanding the diag_table format, but the first column should reflect the module names for the diagnostic coordinate systems?

@marshallward
Copy link
Collaborator

marshallward commented Apr 29, 2020

Looks like you are correct. All the diag_table that I can see have _z for the z-interpolated diagnostics, and this is the line where the module name is assigned:

    new_module_name = trim(module_name)//'_'//trim(diag_cs%diag_remap_cs(i)%diag_module_suffix)

I'll merge this if there's no objections.

@ashao
Copy link
Collaborator

ashao commented Apr 29, 2020

I agree with @angus-g's correction to the documentation

@marshallward
Copy link
Collaborator

Thanks @ashao

(NOTE: Skipping regression since does not touch any source code)

@marshallward marshallward merged commit 12853fa into mom-ocean:dev/gfdl Apr 29, 2020
@angus-g angus-g deleted the patch-1 branch January 18, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants