Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix out of bounds when nrows == 1 #1104

Merged
merged 1 commit into from
May 7, 2020

Conversation

raphaeldussin
Copy link
Contributor

when using with internal_tides, I encountered a case where layers get merged into one
and create an array out-of-bounds issue. @Hallberg-NOAA suggested this fix and it solved my problem.

@codecov-io
Copy link

Codecov Report

Merging #1104 into dev/gfdl will increase coverage by 0.30%.
The diff coverage is 50.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1104      +/-   ##
============================================
+ Coverage     45.76%   46.06%   +0.30%     
============================================
  Files           215      214       -1     
  Lines         69638    69361     -277     
============================================
+ Hits          31872    31954      +82     
+ Misses        37766    37407     -359     
Impacted Files Coverage Δ
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MOM_surface_forcing.F90 27.90% <0.00%> (ø)
...nfig_src/solo_driver/Neverland_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
src/core/MOM_PressureForce_analytic_FV.F90 44.18% <ø> (ø)
src/core/MOM_variables.F90 57.77% <ø> (ø)
src/diagnostics/MOM_debugging.F90 13.21% <0.00%> (-0.08%) ⬇️
src/diagnostics/MOM_wave_speed.F90 42.66% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf.F90 0.00% <0.00%> (ø)
src/ice_shelf/MOM_marine_ice.F90 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6d7c6...450e954. Read the comment docs.

@raphaeldussin
Copy link
Contributor Author

@marshallward @adcroft this one should be an easy one to review

@marshallward
Copy link
Collaborator

Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/commits/pr/1104

Test has passed; no regressions.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this commit is correct and will fix a clear problem. I approve.

@Hallberg-NOAA Hallberg-NOAA merged commit 70cfd64 into mom-ocean:dev/gfdl May 7, 2020
@raphaeldussin raphaeldussin deleted the tridiag_det_fix branch November 19, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants