Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure calls via framework directory #1173

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

Hallberg-NOAA
Copy link
Collaborator

Revised module use statements and some infrastructure calls to go via the
MOM6 framework directory rather than directly calling FMS infrastructure
routines. All answers are bitwise identical.

  Revised module use statements and some infrastructure calls to go via the
MOM6 framework directory rather than directly calling FMS infrastructure
routines.  All answers are bitwise identical.
@codecov-commenter
Copy link

Codecov Report

Merging #1173 into dev/gfdl will decrease coverage by 0.13%.
The diff coverage is 40.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1173      +/-   ##
============================================
- Coverage     46.08%   45.94%   -0.14%     
============================================
  Files           214      224      +10     
  Lines         69399    70495    +1096     
============================================
+ Hits          31984    32392     +408     
- Misses        37415    38103     +688     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MOM_driver.F90 68.72% <ø> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d557d9...cbbf848. Read the comment docs.

@marshallward marshallward self-assigned this Aug 7, 2020
@marshallward
Copy link
Collaborator

marshallward commented Aug 7, 2020

Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/commits/pr/1173

Test passed; no regressions. 🎉

@marshallward marshallward merged commit f16c250 into mom-ocean:dev/gfdl Aug 7, 2020
@Hallberg-NOAA Hallberg-NOAA deleted the infra_via_framework branch July 30, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants