(*)Fix code problems that appear in ISOMIP cases #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set dSV_dT and dSV_dS if present in applyBoundaryFluxesInOut, even if boundary fluxes are not associated. With this change, setting BUOY_CONFIG='NONE' and BUOY_CONFIG='zero' both work and give similar (but not identical) answers in some test cases with an ePBL boundary layer parameterization, whereas before answers were tainted with uninitialized values when BUOY_CONFIG='NONE'. All answers in the existing MOM6-examples test suite are bitwise identical, but answers can change in other cases.
Corrected a horizontal indexing bug in int_density_dz_linear that caused the ISOMIP/layer test case to fail. This bug was first introduced with PR#732 on March 8, 2018. This bug fix will change answers with a linear equation of state and the finite volume pressure gradient force, however it does not change any of the verified answers in the MOM6-examples regression suite.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1175 +/- ##
============================================
- Coverage 46.08% 45.95% -0.14%
============================================
Files 214 224 +10
Lines 69399 70505 +1106
============================================
+ Hits 31984 32398 +414
- Misses 37415 38107 +692
Continue to review full report at Codecov.
|
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/10959 Regression tests have passed. |
marshallward
approved these changes
Aug 10, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems that will allow the ISOMIP/layer test case and
related configurations to work again as originally intended. It corrected a
horizontal indexing bug in int_density_dz_linear that caused the ISOMIP/layer
test case to fail; this bug was first introduced with PR#732 on March 8, 2018.
Additionally, there is new code to set dSV_dT and dSV_dS if present in
applyBoundaryFluxesInOut, even if boundary fluxes are not associated.
These code changes will change answers with a linear equation of state and the
finite volume pressure gradient force, or in other uncommon cases with an ePBL
boundary layer parameterization and no buoyancy fluxes, however they does not
change any of the verified answers in the MOM6-examples regression suite and all
output files are unchanged
The commits in this PR include: