+Move find_interfaces to MOM_state_initialization #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified and cleaned up find_interfaces and moved it from MOM_tracer_Z_init to MOM_state_initialization, reflecting the fact that it is only used from within MOM_state_initialization and that it has very little to do with tracer initialization. The subroutine fast_bisect was inlined into find_interfaces and the stand-alone version was deleted. One minor bug that could change answers was noted but not corrected. All answers are bitwise identical, but the previously publicly visible interface to find_interfaces was made private to the MOM_state_initialization module.
|
Gaea regression tests: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11009 Passed, no regressions. |
marshallward
approved these changes
Aug 18, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified and cleaned up find_interfaces and moved it from MOM_tracer_Z_init
to MOM_state_initialization, reflecting the fact that it is only used from
within MOM_state_initialization and that it has very little to do with tracer
initialization. The subroutine fast_bisect was inlined into find_interfaces
and the stand-alone version was deleted. One minor bug that does change
answers was noted but not corrected. All answers are bitwise identical, but
the previously publicly visible interface to find_interfaces was made private
to the MOM_state_initialization module.