Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed downsampling for x:sum y:point z:point diags #1364

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Fixed downsampling for x:sum y:point z:point diags #1364

merged 3 commits into from
Apr 7, 2021

Commits on Apr 1, 2021

  1. Fixed downsampling for x:sum y:point z:point diags 

    - previous code had averaging instead of summation for
  SPP (x:sum,y:point,z:point) diagnostics
- corrects an issue where these diagnostics were incorrect
  by approximately a factor of 2.
- Orginially found when analyzing the depth-integrated
  temperature advection diagnostic (T_ady_2d)
    @jkrasting
    jkrasting committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    9792b23 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Fixed downsampling summation for more diag types 

    - Fixes for SSP (x:sum;y:sum,z:point) and
  PSP (x:point,y:sum,z:point) diagnostics
- Removed unused `total_weight` arrays in these cases
    @jkrasting
    jkrasting committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    5f06304 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Merge branch 'dev/gfdl' into downsampled_diag_fix

    @Hallberg-NOAA
    Hallberg-NOAA authored Apr 6, 2021
    Configuration menu
    Copy the full SHA
    a5fb365 View commit details
    Browse the repository at this point in the history