+Make MOM_read_data work when 4-d arrays exist #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added internal branches of the infra/FMS1 version of MOM_read_data that work when there are 4-d arrays with a fifth time dimension in the file that is being read, which was previously failing even if the variable that is being read has fewer dimensions, due to code limitations within the fms_io read_data routines. These new branches are selected via the new optional argument file_may_be_4d. The infra/FMS2 versions also have the same new optional argument, although in that case it does nothing. All answers are bitwise identical in the cases that worked previously, but SIS2 restart files can now be read via the MOM6 infrastructure interfaces.
Added the optional argument global_file to all of the overloaded MOM_read_data routines, to indicate whether the file being read is global or is domain- decomposed using the IO-layout. With FMS2, this change does nothing, but with FMS1 it is needed to correctly read from decomposed files that might include 4-d arrays. With this change there are versions of SIS2 that reproduce across restarts without using the FMS1 restart routines. All answers are bitwise identical, but there are new optional arguments.
|
There was some discussion about whether |
marshallward
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added internal branches of the infra/FMS1 version of MOM_read_data that work
when there are 4-d arrays with a fifth time dimension in the file that is being
read, which was previously failing even if the variable that is being read has
fewer dimensions, due to code limitations within the fms_io read_data routines.
These new branches are selected via the new optional argument file_may_be_4d.
The infra/FMS2 versions also have the same new optional argument, although in
that case it does nothing. All answers are bitwise identical in the cases that
worked previously, but SIS2 restart files can now be read via the MOM6
infrastructure interfaces.